better partial config update

backend/appsettings/serializers.py

@@ -64,7 +64,7 @@ class AppConfigAppSerializer(
     enable_snapshot = serializers.BooleanField()
 
 
-class AppConfigSerializer(serializers.Serializer):
+class AppConfigSerializer(ValidateUnknownFieldsMixin, serializers.Serializer):
     """serialize appconfig"""
 
     subscriptions = AppConfigSubSerializer(required=False)

backend/appsettings/views.py

@@ -177,8 +177,8 @@ class AppConfigApiView(ApiBaseView):
         },
     )
     def post(request):
-        """update config values, partial"""
+        """update config values, allows partial update"""
-        serializer = AppConfigSerializer(data=request.data)
+        serializer = AppConfigSerializer(data=request.data, partial=True)
         serializer.is_valid(raise_exception=True)
         validated_data = serializer.validated_data
         updated_config = AppConfig().update_config(validated_data)

backend/user/serializers.py

@@ -48,13 +48,6 @@ class UserMeConfigSerializer(serializers.Serializer):
     show_subed_only = serializers.BooleanField()
     show_help_text = serializers.BooleanField()
 
-    def __init__(self, *args, required=True, **kwargs):
-        super().__init__(*args, **kwargs)
-
-        # Override 'required' for all fields if provided
-        for field in self.fields.values():
-            field.required = required
-
 
 class LoginSerializer(serializers.Serializer):
     """serialize login"""

backend/user/views.py

@@ -61,7 +61,7 @@ class UserConfigView(ApiBaseView):
         """update config, allows partial update"""
 
         data_serializer = UserMeConfigSerializer(
-            data=request.data, required=False
+            data=request.data, partial=True
         )
         data_serializer.is_valid(raise_exception=True)
         validated_data = data_serializer.validated_data

frontend/src/api/actions/updateAppsettingsConfig.ts

@@ -1,12 +1,10 @@
 import APIClient from '../../functions/APIClient';
+import { AppSettingsConfigType } from '../loader/loadAppsettingsConfig';
 
-const updateAppsettingsConfig = async (
+const updateAppsettingsConfig = async (updatedConfig: Partial<AppSettingsConfigType>) => {
-  configKey: string,
-  configValue: string | boolean | number | null,
-) => {
   return APIClient('/api/appsettings/config/', {
     method: 'POST',
-    body: { [configKey]: configValue },
+    body: updatedConfig,
   });
 };
 

frontend/src/pages/SettingsApplication.tsx

@@ -151,7 +151,9 @@ const SettingsApplication = () => {
     configKey: string,
     configValue: string | boolean | number | null,
   ) => {
-    await updateAppsettingsConfig(configKey, configValue);
+    const [group, key] = configKey.split('.');
+    const updatedConfig = { [group]: { [key]: configValue } } as Partial<AppSettingsConfigType>;
+    await updateAppsettingsConfig(updatedConfig);
     setRefresh(true);
   };