public/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/liyunfan1223/azerothcore-wotlk.git synced 2026-08-09 08:17:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(Core/Spells): Remove effectively unused switch case. (#22284)

Browse Source
This commit is contained in:
Benjamin Jackson
2025-06-07 03:24:50 -04:00
committed by GitHub
parent 90a101cedb
commit da7db0a510
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/server/game/Spells/SpellInfo.cpp
View File

@@ -2644,14 +2644,6 @@ bool SpellInfo::_IsPositiveEffect(uint8 effIndex, bool deep) const
switch (Effects[effIndex].Effect) switch (Effects[effIndex].Effect)
{ {
case SPELL_EFFECT_DUMMY:
// some explicitly required dummy effect sets
switch (Id)
{
default:
break;
}
break;
// always positive effects (check before target checks that provided non-positive result in some case for positive effects) // always positive effects (check before target checks that provided non-positive result in some case for positive effects)
case SPELL_EFFECT_HEAL: case SPELL_EFFECT_HEAL:
case SPELL_EFFECT_LEARN_SPELL: case SPELL_EFFECT_LEARN_SPELL:
@@ -2661,10 +2653,8 @@ bool SpellInfo::_IsPositiveEffect(uint8 effIndex, bool deep) const
return true; return true;
case SPELL_EFFECT_APPLY_AREA_AURA_ENEMY: case SPELL_EFFECT_APPLY_AREA_AURA_ENEMY:
return false; return false;
case SPELL_EFFECT_GAMEOBJECT_DAMAGE: case SPELL_EFFECT_GAMEOBJECT_DAMAGE:
return false; return false;
case SPELL_EFFECT_SCHOOL_DAMAGE: case SPELL_EFFECT_SCHOOL_DAMAGE:
{ {
bool only = true; bool only = true;
@@ -2688,7 +2678,6 @@ bool SpellInfo::_IsPositiveEffect(uint8 effIndex, bool deep) const
return false; return false;
break; break;
} }
// non-positive aura use // non-positive aura use
case SPELL_EFFECT_APPLY_AURA: case SPELL_EFFECT_APPLY_AURA:
case SPELL_EFFECT_APPLY_AREA_AURA_FRIEND: case SPELL_EFFECT_APPLY_AREA_AURA_FRIEND: