public/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/liyunfan1223/azerothcore-wotlk.git synced 2026-08-09 08:17:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Scripts/Mage): stop Mirror Image from breaking crowd control (#26458)

Browse Source 
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Andrew
2026-07-10 12:41:33 -03:00
committed by GitHub
parent 4472155a6d
commit cfee83d19f
1 changed files with 32 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/server/scripts/Pet/pet_mage.cpp
View File

@@ -36,7 +36,9 @@ enum MageSpells
SPELL_SUMMON_MIRROR_IMAGE1 = 58831, SPELL_SUMMON_MIRROR_IMAGE1 = 58831,
SPELL_SUMMON_MIRROR_IMAGE2 = 58833, SPELL_SUMMON_MIRROR_IMAGE2 = 58833,
SPELL_SUMMON_MIRROR_IMAGE3 = 58834, SPELL_SUMMON_MIRROR_IMAGE3 = 58834,
SPELL_SUMMON_MIRROR_IMAGE_GLYPH = 65047 SPELL_SUMMON_MIRROR_IMAGE_GLYPH = 65047,
SPELL_MAGE_MIRROR_IMAGE_FROSTBOLT = 59638,
SPELL_MAGE_MIRROR_IMAGE_FIRE_BLAST = 59637
}; };
class DeathEvent : public BasicEvent class DeathEvent : public BasicEvent
@@ -202,24 +204,45 @@ struct npc_pet_mage_mirror_image : CasterAI
return; return;
} }
checktarget += diff; // A dead target, or one we lost sight of, is invalid: drop it and reselect.
// CanSeeOrDetect is comparatively expensive, so throttle the sight check to ~1s.
bool lostTarget = !me->GetVictim()->IsAlive();
checktarget += diff;
if (checktarget >= 1000) if (checktarget >= 1000)
{ {
if (!me->GetVictim()->IsAlive() || me->GetVictim()->HasBreakableByDamageCrowdControlAura() || !me->CanSeeOrDetect(me->GetVictim())) checktarget = 0;
{ if (!me->CanSeeOrDetect(me->GetVictim()))
MySelectNextTarget(); lostTarget = true;
me->InterruptNonMeleeSpells(true);
return;
}
} }
if (lostTarget)
{
MySelectNextTarget();
me->InterruptNonMeleeSpells(false);
return;
}
// A cast already in progress when the crowd control lands is allowed to finish (3.1.2),
// except a Frostbolt on a target that is now Polymorphed: 3.2.0 cancels that cast so it
// cannot break the Polymorph. Other breakable CC keeps the "let it finish" behaviour.
if (me->HasUnitState(UNIT_STATE_CASTING)) if (me->HasUnitState(UNIT_STATE_CASTING))
{
if (me->GetVictim()->HasAuraWithMechanic(1ULL << MECHANIC_POLYMORPH)
&& me->FindCurrentSpellBySpellId(SPELL_MAGE_MIRROR_IMAGE_FROSTBOLT))
me->InterruptNonMeleeSpells(false, SPELL_MAGE_MIRROR_IMAGE_FROSTBOLT);
return;
}
// Never start a new cast on a target under a breakable-by-damage CC aura (Polymorph,
// Dragon's Breath, ...) - that is what would break the crowd control.
if (me->GetVictim()->HasBreakableByDamageCrowdControlAura(me))
return; return;
if (uint32 spellId = events.ExecuteEvent()) if (uint32 spellId = events.ExecuteEvent())
{ {
events.RescheduleEvent(spellId, spellId == 59637 ? 6500ms : 2500ms); events.RescheduleEvent(spellId, spellId == SPELL_MAGE_MIRROR_IMAGE_FIRE_BLAST ? 6500ms : 2500ms);
me->CastSpell(me->GetVictim(), spellId, false); me->CastSpell(me->GetVictim(), spellId, false);
} }
} }