From f7eae55ebdca5d13637d84951cea205019992244 Mon Sep 17 00:00:00 2001 From: Andrew <47818697+Nyeriah@users.noreply.github.com> Date: Sat, 25 Jul 2026 16:02:34 -0300 Subject: [PATCH 1/7] fix(Scripts/TempleOfAhnQiraj): fix GCC/Clang build error in Skeram aggro yell (#26802) --- src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp b/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp index 4661185b3..f47580b5e 100644 --- a/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp +++ b/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp @@ -16,6 +16,7 @@ */ #include "CreatureScript.h" +#include "Player.h" #include "ScriptedCreature.h" #include "SpellScript.h" #include "SpellScriptLoader.h" @@ -155,7 +156,7 @@ struct boss_skeram : public BossAI if (!me->IsSummon()) { // Resolve pets/guardians to their owner so gendered locales resolve $g against the puller - Player* puller = who->GetCharmerOrOwnerPlayerOrPlayerItself(); + Unit* puller = who->GetCharmerOrOwnerPlayerOrPlayerItself(); Talk(SAY_AGGRO, puller ? puller : who); } } From 7069d99dca92ef21eaf9cb34a72a825470a78414 Mon Sep 17 00:00:00 2001 From: daobashun <49193927+fangshun2004@users.noreply.github.com> Date: Sun, 26 Jul 2026 03:47:25 +0800 Subject: [PATCH 2/7] fix(Scripts/ScarletMonastery): Scarlet Monastery Forgiveness Spell Visual (#26454) --- .../rev_1783128746972420200.sql | 13 ++++ .../instance_scarlet_monastery.cpp | 71 +++++++++++++++---- 2 files changed, 72 insertions(+), 12 deletions(-) create mode 100644 data/sql/updates/pending_db_world/rev_1783128746972420200.sql diff --git a/data/sql/updates/pending_db_world/rev_1783128746972420200.sql b/data/sql/updates/pending_db_world/rev_1783128746972420200.sql new file mode 100644 index 000000000..bc5e22aa6 --- /dev/null +++ b/data/sql/updates/pending_db_world/rev_1783128746972420200.sql @@ -0,0 +1,13 @@ +-- SPELL_TRANSFORM_GHOST and SPELL_FORGIVENESS + +DELETE FROM `spell_script_names` WHERE `spell_id` IN (28443, 28697); +INSERT INTO `spell_script_names` (`spell_id`, `ScriptName`) VALUES +(28443, 'spell_transform_ghost_visual'), +(28697, 'spell_forgiveness_dummy_visual'); + +-- Smartscript +-- Deleted 28 due to SPELL_FORGIVENESS attack death +DELETE FROM `smart_scripts` WHERE (`entryorguid` = 3976) AND (`source_type` = 0) AND (`id` IN (24, 28, 29)); +INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `event_param6`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES +(3976, 0, 24, 28, 61, 0, 100, 0, 0, 0, 0, 0, 0, 0, 49, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 'Scarlet Commander Mograine - On Reached Point 1 - Start Attacking'),-- Change link 29 to 28 +(3976, 0, 28, 0, 61, 0, 100, 0, 0, 0, 0, 0, 0, 0, 117, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Scarlet Commander Mograine - On Reached Point 1 - Enable Evade');-- Change id 29 to 28 diff --git a/src/server/scripts/EasternKingdoms/ScarletMonastery/instance_scarlet_monastery.cpp b/src/server/scripts/EasternKingdoms/ScarletMonastery/instance_scarlet_monastery.cpp index 04e2e1337..ba72ead37 100644 --- a/src/server/scripts/EasternKingdoms/ScarletMonastery/instance_scarlet_monastery.cpp +++ b/src/server/scripts/EasternKingdoms/ScarletMonastery/instance_scarlet_monastery.cpp @@ -18,6 +18,8 @@ #include "InstanceMapScript.h" #include "scarletmonastery.h" #include "ScriptedCreature.h" +#include "SpellScript.h" +#include "SpellScriptLoader.h" enum AshbringerEventMisc { @@ -39,17 +41,6 @@ enum AshbringerEventMisc GO_HIGH_INQUISITOR_DOOR = 104600 }; -enum AshbringerSpell -{ - //Highlord Mograine Spells - //Needs Fix: Increased the visual effect of spells on hit - SPELL_FORGIVENESS = 28697, - - //High Inquisitor Fairbanks - //Needs Fix: Increased the visual effect of spells on hit - SPELL_TRANSFORM_GHOST = 28443 -}; - enum DataTypes { TYPE_MOGRAINE_AND_WHITE_EVENT = 1, @@ -66,7 +57,7 @@ enum DataTypes GAMEOBJECT_PUMPKIN_SHRINE = 10 }; -float const CATHEDRAL_PULL_RANGE = 80.0f; // Distance from the Cathedral doors to where Mograine is standing +float constexpr CATHEDRAL_PULL_RANGE = 80.0f; // Distance from the Cathedral doors to where Mograine is standing class instance_scarlet_monastery : public InstanceMapScript { @@ -271,7 +262,63 @@ public: }; }; +enum AshbringerSpell +{ + SPELL_FORGIVENESS = 28697, + SPELL_FORGIVENESS_IMPACTKIT = 317, + SPELL_TRANSFORM_GHOST = 28443, + SPELL_TRANSFORM_IMPACTKIT=500 +}; + +// SPELL_FORGIVENESS = 28697 +class spell_forgiveness_dummy_visual : public SpellScript +{ + PrepareSpellScript(spell_forgiveness_dummy_visual); + + void HandleDummy(SpellEffIndex /*effIndex*/) + { + Unit* target = GetHitUnit(); + if (!target) + return; + + target->SendPlaySpellVisual(SPELL_FORGIVENESS_IMPACTKIT);//SPELL_FORGIVENESS IMPACTKIT 317 SpellVisualEntry.ImpactKit can't be used + + //Delay death to prevent the death of the creature from interrupting the animation display + target->m_Events.AddEventAtOffset([target]() -> void + { + target->KillSelf(); + }, 500ms); + } + + void Register() override + { + OnEffectHitTarget += SpellEffectFn(spell_forgiveness_dummy_visual::HandleDummy, EFFECT_0, SPELL_EFFECT_DUMMY); + } +}; + +// SPELL_TRANSFORM_GHOST = 28443 +class spell_transform_ghost_visual: public SpellScript +{ + PrepareSpellScript(spell_transform_ghost_visual); + + void HandleAfterHit() + { + Unit* target = GetHitUnit(); + if (!target) + return; + + target->SendPlaySpellVisual(SPELL_TRANSFORM_IMPACTKIT); //SPELL_TRANSFORM_GHOST IMPACTKIT 500 + } + + void Register() override + { + AfterHit += SpellHitFn(spell_transform_ghost_visual::HandleAfterHit); + } +}; + void AddSC_instance_scarlet_monastery() { new instance_scarlet_monastery(); + RegisterSpellScript(spell_forgiveness_dummy_visual); + RegisterSpellScript(spell_transform_ghost_visual); } From b011852698d2771b548a216433a32d5a209081d7 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sat, 25 Jul 2026 19:48:41 +0000 Subject: [PATCH 3/7] chore(DB): import pending files Referenced commit(s): 7069d99dca92ef21eaf9cb34a72a825470a78414 --- .../rev_1783128746972420200.sql => db_world/2026_07_25_01.sql} | 1 + 1 file changed, 1 insertion(+) rename data/sql/updates/{pending_db_world/rev_1783128746972420200.sql => db_world/2026_07_25_01.sql} (96%) diff --git a/data/sql/updates/pending_db_world/rev_1783128746972420200.sql b/data/sql/updates/db_world/2026_07_25_01.sql similarity index 96% rename from data/sql/updates/pending_db_world/rev_1783128746972420200.sql rename to data/sql/updates/db_world/2026_07_25_01.sql index bc5e22aa6..f992603f1 100644 --- a/data/sql/updates/pending_db_world/rev_1783128746972420200.sql +++ b/data/sql/updates/db_world/2026_07_25_01.sql @@ -1,3 +1,4 @@ +-- DB update 2026_07_25_00 -> 2026_07_25_01 -- SPELL_TRANSFORM_GHOST and SPELL_FORGIVENESS DELETE FROM `spell_script_names` WHERE `spell_id` IN (28443, 28697); From 4bc5d1eeafffe34d8bb6ee65b7e56f86422c60f2 Mon Sep 17 00:00:00 2001 From: Gultask <100873791+Gultask@users.noreply.github.com> Date: Sat, 25 Jul 2026 17:02:39 -0300 Subject: [PATCH 4/7] fix(DB/Quest): Remove Redundant Quest Credit in Rescue from Town Square (#26797) --- data/sql/updates/pending_db_world/rev_1784999317478287400.sql | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 data/sql/updates/pending_db_world/rev_1784999317478287400.sql diff --git a/data/sql/updates/pending_db_world/rev_1784999317478287400.sql b/data/sql/updates/pending_db_world/rev_1784999317478287400.sql new file mode 100644 index 000000000..bd6c2b56d --- /dev/null +++ b/data/sql/updates/pending_db_world/rev_1784999317478287400.sql @@ -0,0 +1,2 @@ +-- +UPDATE `creature_template` SET `KillCredit1` = 0 WHERE (`entry` = 27370); From 7f8955e7404dc503a57edbc0b4f6c988205bd08b Mon Sep 17 00:00:00 2001 From: Gultask <100873791+Gultask@users.noreply.github.com> Date: Sat, 25 Jul 2026 17:02:57 -0300 Subject: [PATCH 5/7] fix(DB/Quest): Update quest_offer_rewards values for quest End of the Line Horde version (#26798) --- data/sql/updates/pending_db_world/rev_1785000745157250500.sql | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 data/sql/updates/pending_db_world/rev_1785000745157250500.sql diff --git a/data/sql/updates/pending_db_world/rev_1785000745157250500.sql b/data/sql/updates/pending_db_world/rev_1785000745157250500.sql new file mode 100644 index 000000000..5e77636c1 --- /dev/null +++ b/data/sql/updates/pending_db_world/rev_1785000745157250500.sql @@ -0,0 +1,2 @@ +-- +UPDATE `quest_offer_reward` SET `Emote1` = 5, `Emote2` = 1, `Emote3` = 1, `EmoteDelay2` = 1000, `RewardText` = 'WHAT?!$B$B$B$BOf course, we should have guessed that this was what they were up to all along. Quickly, there\'s no time to waste.$B$BWyrmrest must be warned!' WHERE (`ID` = 12110); From 5485cebf4143be7d355ce2a2f5b235e656a99392 Mon Sep 17 00:00:00 2001 From: Gultask <100873791+Gultask@users.noreply.github.com> Date: Sat, 25 Jul 2026 17:03:09 -0300 Subject: [PATCH 6/7] fix(DB/Creature): Sniff Bjomolf (#26800) --- .../rev_1785003613580466900.sql | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 data/sql/updates/pending_db_world/rev_1785003613580466900.sql diff --git a/data/sql/updates/pending_db_world/rev_1785003613580466900.sql b/data/sql/updates/pending_db_world/rev_1785003613580466900.sql new file mode 100644 index 000000000..34ea23d5a --- /dev/null +++ b/data/sql/updates/pending_db_world/rev_1785003613580466900.sql @@ -0,0 +1,29 @@ +-- +DELETE FROM `creature` WHERE (`id` = 24516) AND (`guid` IN (114439, 114440)); +INSERT INTO `creature` (`guid`, `id`, `map`, `zoneId`, `areaId`, `spawnMask`, `phaseMask`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `wander_distance`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `ScriptName`, `Comment`, `CreateObject`, `VerifiedBuild`) VALUES +(114439, 24516, 571, 0, 0, 1, 1, 0, 2319.6106, -3020.8176, 136.57187, 2.20952, 300, 0, 0, 0, 0, 2, 0, 0, 0, '', NULL, 1, 65512); + +DELETE FROM `creature_addon` WHERE `guid` = 114439; +INSERT INTO `creature_addon` (`guid`, `path_id`) VALUES +(114439, 1144390); + +DELETE FROM `waypoint_data` WHERE `id` = 1144390; +INSERT INTO `waypoint_data` (`id`, `point`, `position_x`, `position_y`, `position_z`, `orientation`) VALUES +(1144390, 1 , 2319.6106, -3020.8176, 136.57187, NULL), +(1144390, 2 , 2293.5505, -3033.0613, 136.70703, NULL), +(1144390, 3 , 2270.9585, -3049.1892, 136.7957, NULL), +(1144390, 4 , 2261.9817, -3069.591, 137.1125, NULL), +(1144390, 5 , 2244.4805, -3111.4001, 136.79797, NULL), +(1144390, 6 , 2234.3372, -3129.741, 138.23094, NULL), +(1144390, 7 , 2205.1501, -3149.454, 140.47078, NULL), +(1144390, 8 , 2178.7832, -3143.6543, 139.04956, NULL), +(1144390, 9 , 2159.131, -3118.843, 138.94107, NULL), +(1144390, 10, 2157.4236, -3090.9448, 138.66618, NULL), +(1144390, 11, 2184.6926, -3076.7776, 137.69681, NULL), +(1144390, 12, 2205.2817, -3067.4485, 138.47263, NULL), +(1144390, 13, 2241.1084, -3040.399, 136.02086, NULL), +(1144390, 14, 2251.2544, -3001.0442, 135.393, NULL), +(1144390, 15, 2261.8438, -2975.5894, 137.61548, NULL), +(1144390, 16, 2288.5696, -2967.9568, 134.09793, NULL), +(1144390, 17, 2312.0784, -2973.8508, 131.73712, NULL), +(1144390, 18, 2327.24, -2996.011, 135.02109, NULL); From 9416d4a0b50636e6fc1a689f6606e5ff576bdee6 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sat, 25 Jul 2026 20:03:56 +0000 Subject: [PATCH 7/7] chore(DB): import pending files Referenced commit(s): 4bc5d1eeafffe34d8bb6ee65b7e56f86422c60f2 --- .../rev_1784999317478287400.sql => db_world/2026_07_25_02.sql} | 1 + .../rev_1785000745157250500.sql => db_world/2026_07_25_03.sql} | 1 + .../rev_1785003613580466900.sql => db_world/2026_07_25_04.sql} | 1 + 3 files changed, 3 insertions(+) rename data/sql/updates/{pending_db_world/rev_1784999317478287400.sql => db_world/2026_07_25_02.sql} (63%) rename data/sql/updates/{pending_db_world/rev_1785000745157250500.sql => db_world/2026_07_25_03.sql} (89%) rename data/sql/updates/{pending_db_world/rev_1785003613580466900.sql => db_world/2026_07_25_04.sql} (97%) diff --git a/data/sql/updates/pending_db_world/rev_1784999317478287400.sql b/data/sql/updates/db_world/2026_07_25_02.sql similarity index 63% rename from data/sql/updates/pending_db_world/rev_1784999317478287400.sql rename to data/sql/updates/db_world/2026_07_25_02.sql index bd6c2b56d..018e4ae17 100644 --- a/data/sql/updates/pending_db_world/rev_1784999317478287400.sql +++ b/data/sql/updates/db_world/2026_07_25_02.sql @@ -1,2 +1,3 @@ +-- DB update 2026_07_25_01 -> 2026_07_25_02 -- UPDATE `creature_template` SET `KillCredit1` = 0 WHERE (`entry` = 27370); diff --git a/data/sql/updates/pending_db_world/rev_1785000745157250500.sql b/data/sql/updates/db_world/2026_07_25_03.sql similarity index 89% rename from data/sql/updates/pending_db_world/rev_1785000745157250500.sql rename to data/sql/updates/db_world/2026_07_25_03.sql index 5e77636c1..1dbb9facd 100644 --- a/data/sql/updates/pending_db_world/rev_1785000745157250500.sql +++ b/data/sql/updates/db_world/2026_07_25_03.sql @@ -1,2 +1,3 @@ +-- DB update 2026_07_25_02 -> 2026_07_25_03 -- UPDATE `quest_offer_reward` SET `Emote1` = 5, `Emote2` = 1, `Emote3` = 1, `EmoteDelay2` = 1000, `RewardText` = 'WHAT?!$B$B$B$BOf course, we should have guessed that this was what they were up to all along. Quickly, there\'s no time to waste.$B$BWyrmrest must be warned!' WHERE (`ID` = 12110); diff --git a/data/sql/updates/pending_db_world/rev_1785003613580466900.sql b/data/sql/updates/db_world/2026_07_25_04.sql similarity index 97% rename from data/sql/updates/pending_db_world/rev_1785003613580466900.sql rename to data/sql/updates/db_world/2026_07_25_04.sql index 34ea23d5a..7e141cc22 100644 --- a/data/sql/updates/pending_db_world/rev_1785003613580466900.sql +++ b/data/sql/updates/db_world/2026_07_25_04.sql @@ -1,3 +1,4 @@ +-- DB update 2026_07_25_03 -> 2026_07_25_04 -- DELETE FROM `creature` WHERE (`id` = 24516) AND (`guid` IN (114439, 114440)); INSERT INTO `creature` (`guid`, `id`, `map`, `zoneId`, `areaId`, `spawnMask`, `phaseMask`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `wander_distance`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `ScriptName`, `Comment`, `CreateObject`, `VerifiedBuild`) VALUES