public/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/liyunfan1223/azerothcore-wotlk.git synced 2026-08-08 15:58:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core/Channel): potential nullptr reference in Channel::SetOwner() (#17906)

Browse Source
This commit is contained in:
Tristan 'Natrist' Cormier
2023-11-30 14:25:01 -05:00
committed by GitHub
parent e1cec2bbcf
commit 8eed7ee531
1 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/server/game/Chat/Channels/Channel.cpp
View File

@@ -884,23 +884,25 @@ void Channel::SetOwner(ObjectGuid guid, bool exclaim)
pinfo.SetModerator(true); pinfo.SetModerator(true);
uint8 oldFlag = pinfo.flags; uint8 oldFlag = pinfo.flags;
pinfo.SetOwner(true); pinfo.SetOwner(true);
Player* player = ObjectAccessor::FindPlayer(_ownerGUID);
WorldPacket data;
if (ShouldAnnouncePlayer(player))
{
MakeModeChange(&data, _ownerGUID, oldFlag);
SendToAll(&data);
}
FlagsNotify(pinfo.plrPtr); FlagsNotify(pinfo.plrPtr);
if (exclaim && ShouldAnnouncePlayer(player)) Player* player = ObjectAccessor::FindPlayer(_ownerGUID);
if (player)
{ {
MakeOwnerChanged(&data, _ownerGUID); if (ShouldAnnouncePlayer(player))
SendToAll(&data); {
WorldPacket data;
MakeModeChange(&data, _ownerGUID, oldFlag);
SendToAll(&data);
if (exclaim)
{
// MakeOwnerChanged will reset the packet for us
MakeOwnerChanged(&data, _ownerGUID);
SendToAll(&data);
}
}
} }
} }
} }